I am seeing style issues, specifically with custom fields which are checkbox groups, where they are being represented as small circles (icon-circle-blank class). I am aware of the font awesome differences in open-source versus hosted, but font-awesome has a very useable check mark icon that should be used. Can anyone help with where in the Ruby code the checkbox group gets assigned the icon-circle-blank style class? I have looked in the SCSS Coding Guideline which doesn’t seem to hold true any longer, and also reviewed the font-awesome-min.css but that seems to just create the classes with no assignment for them. Can anyone provide a little help in pointing me to where I can fix this class association?
Thanks!
Rob
(The circles next to the age ranges should be checkmarks as they are in the hosted version of our site.)
I figured out a work-around for this problem. In case it’s useful to anyone it was to:
go to /app/assets/stylesheets/font-awesome-min.css and edit the "icon-circle-blank" style to use value "\f00c" instead of "\f10c".
Run RAILS_ENV=production bundle exec rake assets:precompile
This is more of a hack than a proper solution. The application substitutes the icon-circle-blank style for any icon it can’t find. I could not figure out why it couldn’t find the ss-check style it should be using so I changed the icon for the icon-circle-blank class. This works for me as I don’t ever use the icon-circle-blank class for anything else on my site. If you do, this work-around may cause you problems. As I get better, I may come back and update it with a proper fix!
The circle icon is the default icon that will be shown if the icon is missing. That’s why you are seeing it.
As you mentioned, we are using two different icon sets:
SS pika, which is the one that is used in sharetribe.com. It’s has a license that prevents us including it to the OS repository
Font-awesome, which is the default icon set for font-awesome.
To be honest, since we’re not using font-awesome for sharetribe.com, we have been a bit lazy to keep the font-awesome icon set up to date. If someone wants to update it and make a PR, I’m happy to review and merge it to master!
Have a look at the file /app/view_utils/icon_map.rb. That file implements a mapping from generic icon name to icon set specific icon name. You can see for example, that there’s a mapping that maps check to ss-check for SS pika icon set, but the corresponding mapping is missing for font-awesome. So the proper way to fix the issue you are seeing is to add the missing font-awesome mapping.
